You are here

Bug "Midi file deletion" with QTractor svn 2621

Dear Rui!

I think I found a quite serious bug:

I start a new session and import a midi file with the "Clip/Import ..." function from the menu. It now appears in the window "Files". Now I decide to open a new session, therefore QTractor asks if I want to save the actual session. I click "No", and a new session opens. The old session is closed but the original midi file (not the session) is deleted from its home folder too!

For testing I recommend to copy some midi files to a new folder created for testing purposes! Can you confirm this behaviour?

Cheers,
Michael

Forums: 
rncbc's picture

Can you confirm this behavior?
no, i'm afraid not... but maybe there's something missing left to be told...? :S

anyway, i do take for granted that you have seen this, but can you reproduce that? at will?

nb. that clip/import... only works for midi files iif the current selected track is a midi one. otherwise clip/import... defaults to open audio files. hmm.

is there something i'm not aware of? is there something terribly new? does v0.5.1 suffer from this horror or is it just this recent svn trunk?

hope to know soon what to fix :)
seeya

babarosa's picture

Hi there,

yes, I can reproduce this behaviour which also happens in svn2619 on Xubuntu 10.04. My english is not the best, so I try again to describe my problem:

I launch QTractor, no tracks and no clips are shown. In the "Files"-window the "audio"-tab is activated/in front. Now I select "Clip/Import" from the menu, the "Open Audio Files"-browser launches, by default audio files are selected of course in the drop down list on the bottom of the "Open Audio Files"-browser.

Now I change this setting to "All files (*.*)" to select MIDI-Files which are correctly displayed in the "Open Audio Files"-browser. I select one and press "open". QTractor generates a new blank audio track with no clip in it.

Now I start a new session, QTractor asks if I want to delete the present one, I press "delete" and a new session launches - QTractor not only wipes the session but also the former chosen midi file from its original folder - it is erased from the hard disk!

I hope I described my problem more clearly :-)

Cheers,
Michael

rncbc's picture

now a get it, yes.

or better yet, NO, please don't do that! you're trying to open a midi file where an audio one is supposed to be: look! the dialog window title rightly says "Open Audio Files" so why do you expect it to work on a midi file anyway?

otoh. that's actually a bug in qtractor code path: even if a midi file cannot be imported into an audio clip, it is plain wrong to delete it. actually it is being deleted because the audio clip sees it as an empty audio file (of course, given that's a midi one, which obviously has zero audio samples in it). it is being deleted because, somehow, it assumes it's a recently recorded audio file which is empty.

this deceiving behavior will get fixed asap. however, don't try to reply with any invalid files (eg. midi) where audio files are explicitly being asked for ;)

thanks anyway
cheers

[UPDATE: fixed the non-audio file deletion horror, svn trunk rev.2625+ (aka. qtractor 0.5.1.45+); still, forcing midi files where audio files are requested is NOT a nice move :)]

babarosa's picture

Dear Rui,

I like your kind of humour - but what can I expect from a guy sitting all day in a dark room in front of his computer ;-)
Of course ordinary folks shouldn't open a midi file from an audio file browser, but me? Creativity doesn't follow rules ;-)

At first, I thought I became a victim of qtractor's newly implemented ADDOCM-algorithm!

Thank you for fixing this!

Greetings,
Michael

rncbc's picture

uh? :)

babarosa's picture

... Automatic Detection & Deletion of Crap Music

:-) Michael

rncbc's picture

... Automatic Detection & Deletion of Crap Music
i think i must take a second look into that algorithm: evidence is that *all* files holding my own music (?) are stubbornly still haunting my file-systems...

gosh! ;)

Add new comment